Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Дата
Msg-id 20181230055046.GC608@paquier.xyz
обсуждение исходный текст
Ответ на Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Sat, Dec 29, 2018 at 04:29:28PM +0100, Peter Eisentraut wrote:
> On 22/12/2018 00:42, Michael Paquier wrote:
>> What about the following then?  This is your second proposal except
>> that the sentence refers to the backup current running using "this",
>> which shows better the context in my opinion:
>> "This backup can be canceled safely, but it will not be usable without
>> all the WAL segments.
>
> To much emphasis on the "this" I think, implying that there are other
> backups that cannot be canceled safely.
>
> How about "You can safely cancel this backup, ...".

I can live with that, please find an updated patch.

A personal note on the matter: I tend to prefer using the passive form
in such log messages because they are impersonal, and not use the
direct form because it becomes more personally addressed to the user.
I may be living abroad for too long though ;)
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements