Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Дата
Msg-id
20181230054528.GB608@paquier.xyz
Ответ на
Список
Дерево обсуждения
Clean up some elog messages and comments for do_pg_stop_backup anddo_pg_start_backup Michael Paquier <michael@paquier.xyz>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Michael Paquier <michael@paquier.xyz>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Michael Paquier <michael@paquier.xyz>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Michael Paquier <michael@paquier.xyz>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Michael Paquier <michael@paquier.xyz>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup Michael Paquier <michael@paquier.xyz>
On Sat, Dec 29, 2018 at 04:31:11PM +0100, Peter Eisentraut wrote:
> On 21/12/2018 05:05, Michael Paquier wrote:
>> -	(errmsg("pg_stop_backup cleanup done, waiting for required WAL segments to be archived")));
>> +	(errmsg("waiting for required WAL segments to be archived")));
> 
> I think this loses the context that this is happening during a base
> backup.  I'd keep something like "base backup done, waiting ...".

Okay, point taken.  I'll send a patch after answering to your other
comments. 
--
Michael
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Michael Paquier
Дата:
FAQ