Re: pgsql: Avoid duplicate XIDs at recovery when building initialsnapshot

On Sat, Dec 01, 2018 at 10:51:10AM +0000, Simon Riggs wrote:
> On Fri, 30 Nov 2018 at 23:08, Michael Paquier <michael@paquier.xyz> wrote:
>> It is not complicated to
>> handle duplicates for xacts and subxacts however holding ProcArrayLock
>> for a longer time stresses me as it is already a bottleneck.
>
> I hadn't realised this patch holds ProcArrayLock while removing duplicates.
> Now I know I vote against applying this patch unless someone can show that
> the performance effects of doing so are negligable, which I doubt.

Me too after more thoughts on that.  Please note that I have marked the
patch as returned with feedback for now.
--
Michael