On 2018-Nov-15, David Rowley wrote:
> On 15 November 2018 at 07:10, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > What's with this comment?
> >
> > * Initially we must only set up 1 PartitionDispatch object; the one for
> > * the partitioned table that's the target of the command. If we must
> > * route a tuple via some sub-partitioned table, then its
> > * PartitionDispatch is only built the first time it's required.
> >
> > You're setting the allocsize to PARTITION_ROUTING_INITSIZE, which is at
> > odds with the '1' mentioned in the comment. Which is wrong?
>
> I don't think either is wrong, but I guess something must be
> misleading, so could perhaps be improved.
Ah, that makes sense. Yeah, it seems a bit misleading to me. No
worries.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services