Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS
Дата
Msg-id
20181113000457.GA1336@paquier.xyz
Ответ на
Список
Дерево обсуждения
Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS Michael Paquier <michael@paquier.xyz>
Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS Michael Paquier <michael@paquier.xyz>
On Mon, Nov 12, 2018 at 01:19:31PM -0300, Alvaro Herrera wrote:
> On 2018-Nov-09, Michael Paquier wrote:
>> When doing a set of ON COMMIT DELETE ROWS actions for relations, there
>> is a CCI happening after each truncation:
> 
> Right, but note that this is not a loop so it's only one CCI, not one
> per relation.  (This doesn't seem a big deal either way, but I see no
> reason to have that line there.)

This looks like a lack of caffeine from my side.

>> And I think that I agree with that, because visibly this applies to
>> index rebuilds but in those cases CCIs are happening locally.  So I
>> think that we can get rid of that, and I suggest to remove it only on
>> HEAD only of course.
> 
> +1

Thanks Álvaro for the input, I have committed the change.
--
Michael
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
FAQ