Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS

On 2018-Nov-09, Michael Paquier wrote:

> Hi all,
> 
> When doing a set of ON COMMIT DELETE ROWS actions for relations, there
> is a CCI happening after each truncation:

Right, but note that this is not a loop so it's only one CCI, not one
per relation.  (This doesn't seem a big deal either way, but I see no
reason to have that line there.)

> And I think that I agree with that, because visibly this applies to
> index rebuilds but in those cases CCIs are happening locally.  So I
> think that we can get rid of that, and I suggest to remove it only on
> HEAD only of course.

+1

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services