Re: pg_recvlogical broken in back branches

On Sun, Apr 22, 2018 at 02:55:51PM -0700, Noah Misch wrote:
> That change is testing the wrong variable.  I plan to repair it as
> attached.

You are right here.  Ditto

The whole GetConnection() business in src/bin/pg_basebackup is confusing
with the presence of a global variable.  I am wondering if we should
change GetConnection() to SetConnection().  Most of the routines of
streamutil.c also use "conn" as a local variable while being defined as
a global variable in streamutil.h, which don't help much.
--
Michael