David,
* David Steele (david@pgmasters.net) wrote:
> On 4/6/18 10:22 PM, Stephen Frost wrote:
> > * David Steele (david@pgmasters.net) wrote:
> >> On 4/6/18 6:04 PM, David Steele wrote:
> >>> On 4/6/18 3:02 PM, Stephen Frost wrote:
> >>>>
> >>>> - Further discussion in the commit messages
> >>>
> >>> Agreed, these need some more work. I'm happy to do that but I'll need a
> >>> bit more time. Have a look at the new patches and I'll work on some
> >>> better messages.
> >>
> >> I'm sure you'll want to reword some things, but I think these commit
> >> messages capture the essential changes for each patch.
> >
> > Thanks much. I've taken (most) of these, adjusting a few bits here and
> > there.
> >
> > I've been back over the patch again, mostly improving the commit
> > messages, comments, and docs. I also looked over the code and tests
> > again and they're looking pretty good to me, so I'll be looking to
> > commit this tomorrow afternoon or so US/Eastern.
>
> OK, one last review. I did't make any code changes, but I improved some
> comments, added documentation and fixed a test.
Thanks! I took those and then added a bit more commentary around the
umask() calls in the utilities and fixed a typo or two and then pushed
it.
Time to watch the buildfarm, particularly for Windows hosts just in case
there's something in the regression tests which aren't working correctly
on that platform. I was able to run the full regression suite locally
before committing, though given the recent activity, we may see failures
attributed to this patch which are due to unrelated instability.
Thanks again!
Stephen