On Thu, Apr 5, 2018 at 11:15:20AM +0100, Simon Riggs wrote:
> On 4 April 2018 at 21:28, Simon Riggs <simon@2ndquadrant.com> wrote:
> > On 4 April 2018 at 21:14, Andres Freund <andres@anarazel.de> wrote:
> >
> >>> The normal way is to make review comments that allow change. Your
> >>> request for change of the parser data structures is fine and can be
> >>> done, possibly by Saturday
> >>
> >> I did request changes, and you've so far ignored those requests.
> >
> > Pavan tells me he has replied to you and is working on specific changes.
>
> Specific changes requested have now been implemented by Pavan and
> committed by me.
>
> My understanding is that he is working on a patch for Tom's requested
> parser changes, will post on other thread.
Simon, you have three committers in this thread suggesting this patch be
reverted. Are you just going to barrel ahead with the fixes without
addressing their emails?
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +