Re: Prefix operator for text and spgist support
От | Ildus Kurbangaliev |
---|---|
Тема | Re: Prefix operator for text and spgist support |
Дата | |
Msg-id | 20180312143611.67be88bc@wp.localdomain обсуждение исходный текст |
Ответ на | Re: Prefix operator for text and spgist support (Arthur Zakirov <a.zakirov@postgrespro.ru>) |
Ответы |
Re: Prefix operator for text and spgist support
|
Список | pgsql-hackers |
On Tue, 6 Mar 2018 19:27:21 +0300 Arthur Zakirov <a.zakirov@postgrespro.ru> wrote: > On Mon, Feb 19, 2018 at 05:19:15PM +0300, Ildus Kurbangaliev wrote: > > At brief look at this place seems better to move this block into > > pattern_fixed_prefix function. But there is also `vartype` variable > > which used to in prefix construction, and it would require pass this > > variable too. And since pattern_fixed_prefix called in 10 other > > places and vartype is required only for this ptype it seems better > > just keep this block outside of this function. > > Understood. > > > I've added documentation in current version of the patch. > > Thank you. > > Can you rebase the patch due to changes within pg_proc.h? > > Also here > > + <para> > + There is also the prefix operator <literal>^@</literal> and > corresponding > + <literal>text_startswith</literal> function which covers cases > when only > + searching by beginning of the string is needed. > + </para> > > I think text_startswith should be enclosed with the <function> tag. > I'm not sure, but I think <literal> used for operators, keywords, > etc. I haven't found a manual which describes how to use tags, but > after looking at the documentation where <function> is used, I think > that for function <function> should be used. > Hi, thanks for the review. I've fixed documentation as you said and also rebased to current master. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Вложения
В списке pgsql-hackers по дате отправления: