Re: Set log_line_prefix and application name in test drivers

Поиск
Список
Период
Сортировка
От Christoph Berg
Тема Re: Set log_line_prefix and application name in test drivers
Дата
Msg-id 20160929141820.ks7ykduo7gtrzofz@msg.df7cb.de
обсуждение исходный текст
Ответ на Re: Set log_line_prefix and application name in test drivers  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Set log_line_prefix and application name in test drivers  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Re: Tom Lane 2016-09-29 <16946.1475157978@sss.pgh.pa.us>
> Robert Haas <robertmhaas@gmail.com> writes:
> > As long as we get %t and %p in there we're going to be way ahead, really.
>
> Could we get consensus on just changing the default to
>
>     log_line_prefix = '%t [%p] '
>
> and leaving the rest out of it?  I think pretty much everybody agrees
> that those fields are useful, whereas the rest of it is a lot more
> context-dependent.  (For example, there are a whole lot of real
> installations where neither %u nor %d would be worth the log space.)

Nod. In many installations %u and %d will be effectively constants.

> Personally I'm also on board with using this for regression testing:
>
>     log_line_prefix = '%t [%p] %q%a '
>
> but I doubt it can be sold as a general-purpose default.

I don't think it makes much sense to log only %a unconditionally,
except maybe for making more applications actually set it.

If we were to add more fields I'd go for
log_line_prefix = '%t [%p] %q%u@%d/%a '

but the above-proposed '%t [%p] ' is already fixing 95% of the problem
(and the remaining 5% are unclear).

Possibly the longer version could be added as an example in the
documentation.

So, in short, +1.

Christoph

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tomas Vondra
Дата:
Сообщение: Re: Speed up Clog Access by increasing CLOG buffers
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Bug in to_timestamp().