Re: pg_upgrade: exit_hook_registered variable

Поиск
Список
Период
Сортировка
От Kyotaro HORIGUCHI
Тема Re: pg_upgrade: exit_hook_registered variable
Дата
Msg-id 20160728.192100.59056316.horiguchi.kyotaro@lab.ntt.co.jp
обсуждение исходный текст
Ответ на pg_upgrade: exit_hook_registered variable  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Ответы Re: pg_upgrade: exit_hook_registered variable  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hello,

> I noticed that exit_hook_registered variable in start_postmaster() is
> local variable. Shouldn't it be a static variable?
> 
> I attached a patch. Thank you!

Good catch! It is totally useless unless being static.

But I think it is not necessary to go outside
start_postmaster. Just being static staying in start_postmaster
is enough.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Wrong defeinition of pq_putmessage_noblock since 9.5
Следующее
От: Geoff Winkless
Дата:
Сообщение: Re: Why we lost Uber as a user