Re: Add generate_series(date, date) and generate_series(date, date, integer)

Поиск
Список
Период
Сортировка
От David Steele
Тема Re: Add generate_series(date, date) and generate_series(date, date, integer)
Дата
Msg-id 20160202164101.1291.30526.pgcf@coridan.postgresql.org
обсуждение исходный текст
Ответ на Re: Add generate_series(date,date) and generate_series(date,date,integer)  (Torsten Zühlsdorff <mailinglists@toco-domains.de>)
Ответы Re: Re: Add generate_series(date, date) and generate_series(date, date, integer)  (Corey Huinker <corey.huinker@gmail.com>)
Список pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, failed

Everything looks good except for two minor issues:

1) There should be an informative comment for this struct:

+/* Corey BEGIN */
+typedef struct
+{
+    DateADT        current;
+    DateADT        stop;
+    int32        step;
+} generate_series_date_fctx;

2) There's an extra linefeed after the struct.  Needed?

Regards,
-David

The new status of this patch is: Waiting on Author

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Relation extension scalability