Joshua D. Drake wrote:
> The man page does not clearly state that pg_dump will not dump things like
> users or roles. It does mention briefly in the notes section that pg_dumpall
> is needed for items that are set via SET but that isn't very clear on the
> other items.
I agree that we need a warning about this, but I think it should be a
bit more generic rather than focused exclusively on pg_dumpall; perhaps
something like "global objs such as roles/tblspcs should be backed up
separately, for example using pg_dumpall".
I didn't check the location of the warning in your patch, or whether a
warning is really appropriate rather than, say, <note> or a plain
<para>.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services