Dean,
* Dean Rasheed (dean.a.rasheed@gmail.com) wrote:
> On 21 April 2015 at 20:50, Stephen Frost <sfrost@snowman.net> wrote:
> > Thanks a lot for this. Please take a look at the attached.
>
> I've given this a quick read-through, and it looks good to me. The
> interaction of permissive and restrictive policies from hooks matches
> my expections, and it's a definite improvement having tests for RLS
> hooks.
>
> The only thing I spotted was that the file comment for
> test_rls_hooks.c needs updating.
Fixed!
> Is there any documentation for hooks? If not, perhaps that's something
> we should be considering too.
We don't generally document hooks beyond in the source code.. I'm happy
to expand on what's there, if anyone feels it'd be helpful to do so.
Having the test module is a form of documentation also, of course.
Thanks!
Stephen