On Fri, Jan 30, 2015 at 12:07:22AM -0500, Tom Lane wrote:
> Matt Kelly <mkellycs@gmail.com> writes:
> > On Thu, Jan 29, 2015 at 8:42 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> ... or double. Have you checked that the code behaves properly with
> >> --disable-integer-timestamps?
>
> > I presume you meant --disable-integer-datetimes. I just ran that test case
> > now, all set.
>
> Right, my own sloppiness there.
>
> > For my own edification, was there really any risk of something so trivial
> > breaking due to that setting, or was it just for completeness? (which is a
> > perfectly valid reason)
>
> I hadn't looked at your code at that point, and now that I have, I agree
> it's unlikely to have had a problem with this. Still, it's a good thing
> to check, particularly considering the lack of buildfarm coverage of this
> option :-(.
Given that this has been deprecated for years, maybe it's time we took
it out in 9.5. That the interested parties haven't bothered to put
buildfarm members in that use the option tells me that they're not all
that interested.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate