Re: btree_gist valgrind warnings about uninitialized memory

On 2014-05-13 15:33:08 +0300, Heikki Linnakangas wrote:
> On 05/06/2014 10:03 PM, Andres Freund wrote:
> >Hi,
> >
> >I am not sure whether these are new for 9.4 but they're worth looking at
> >anyway:
> >Valgrind was run with:
> >  --trace-children=yes --quiet \
> >  --track-origins=yes --leak-check=no \
> >  --read-var-info=yes \
> >  --suppressions=/home/andres/src/postgresql/src/tools/valgrind.supp \
> >  <postgres with options>
> >All seem to be due btree_bit's fault and they seem to have a common
> >origin. Didn't look at code.

> I committed a fix to gbt_bit_xfrm() to zero the padding bytes.

Thanks!

> Thanks for the Valgrinding!

That leaves the spgist thing and some infrastructure till we can setup a
valgrind animal... From what we've caught with it so far that seems
rather worthwile.
What's your plans with your spgist fix? Commit it once 9.5 is branched?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services