shouldn't we log permission errors when accessing the configured trigger file?

Hi,


For some reason CheckForStandbyTrigger() doesn't report permission
errors when stat()int the trigger file. Shouldn't we fix that?

static bool
CheckForStandbyTrigger(void)
{
...if (stat(TriggerFile, &stat_buf) == 0){    ereport(LOG,            (errmsg("trigger file found: %s", TriggerFile)));
  unlink(TriggerFile);    triggered = true;    fast_promote = true;    return true;}
 

Imo the stat() should warn about all errors but ENOENT?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services