On Sun, Oct 09, 2011 at 05:50:52PM +0200, Kohei KaiGai wrote:
> [patch v4]
Each revision of this patch yielded a 1.2 MiB email. Please gzip attachments
this large. The two revisions you sent in September constituted 18% of the
pgsql-hackers bits for the month, and the next-largest message was only 315
KiB. Your mailer also picks base64 for textual attachments, needlessly
inflating them by 37%.
At the same time, the patch is large because it rewrites every line in
pg_proc.h. Especially since it leaves proleakproof = 'f' for _all_ rows,
consider instead using an approach like this:
http://archives.postgresql.org/message-id/20110611211304.GB21098@tornado.leadboat.com
These patches were not context diffs.
Thanks,
nm