Re: pgindent run coming

Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> >
> >> I am unclear why struct pointers are not being formatted properly in
> >> function headers but will research it.
> >>
> >
> > Yeah, if we can fix that directly without adding the names to the
> > typedef list, it would be better.  But not something to do right now.
> >
> > Have you started the pgindent run yet?  I have a patch ready for
> > the cursor stability issue, but will hold off committing if it might
> > create a merge problem for you.
> >
> >
> >
>
> I am doing runs as requested on various platforms to extract the typedef
> lists. Linux is done, Windows (mingw) is running, FBSD and Cygwin to come.
>
> Results in a few hours. The buildfarm will have a consolidated list.

OK, good.  However, I am seeing missing typedefs in the Linux list you
posted at:

    http://www.pgbuildfarm.org/cgi-bin/typedefs.pl

I pulled this list 20 minutes ago.  I compared your list to the BSD list
I usually used and found that the Linux list had fewer typedefs:

    2270 typedefs.old
    1848 typedefs.new

I did a diff, attached, and found some typedefs that don't appear, like
PortalData.  That is defined in our code as:

    typedef struct PortalData *Portal;

    typedef struct PortalData
    {
        /* Bookkeeping data */
    ...
        bool        visible;        /* include this portal in pg_cursors? */
    } PortalData;

I will try to build on Linux here and see how objdump displays that,
unless you can get me the output.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
5,16d4
< AMT
< AMTS
< ASN1_BIT_STRING
< ASN1_BMPSTRING
< ASN1_BOOLEAN
< ASN1_CTX
< ASN1_ENCODING
< ASN1_ENUMERATED
< ASN1_GENERALIZEDTIME
< ASN1_GENERALSTRING
< ASN1_HEADER
< ASN1_IA5STRING
18,24d5
< ASN1_ITEM
< ASN1_ITEM_EXP
< ASN1_METHOD
< ASN1_NULL
< ASN1_OBJECT
< ASN1_OCTET_STRING
< ASN1_PRINTABLESTRING
26,36d6
< ASN1_STRING_TABLE
< ASN1_T61STRING
< ASN1_TEMPLATE
< ASN1_TIME
< ASN1_TLC
< ASN1_TYPE
< ASN1_UNIVERSALSTRING
< ASN1_UTCTIME
< ASN1_UTF8STRING
< ASN1_VALUE
< ASN1_VISIBLESTRING
59d28
< AfterTriggerEventDataOneCtid
68d36
< AggHashEntryData
72d39
< AggStatePerAggData
80d46
< AllocBlockData
82d47
< AllocChunkData
142d106
< AutoVacuumSignal
149d112
< BINOP
151d113
< BIO_F_BUFFER_CTX
153d114
< BIO_dummy
156,157d116
< BIT_STRING_BITNAME
< BLOCK
159d117
< BN_BLINDING
161,162d118
< BN_MONT_CTX
< BN_RECP_CTX
175d130
< BTScanPos
184d138
< BUF_MEM
187d140
< BackslashQuoteType
212d164
< BoolPtr
221d172
< BufferAccessStrategyData
231,233d181
< BulkInsertStateData
< Byte
< Bytef
241,259d188
< COMP_CTX
< COMP_METHOD
< CONDOP
< CONF
< CONF_IMODULE
< CONF_METHOD
< CONF_MODULE
< CONF_VALUE
< COP
< CPFunction
< CPPFunction
< CRYPTO_EX_DATA
< CRYPTO_EX_DATA_FUNCS
< CRYPTO_EX_DATA_IMPL
< CRYPTO_EX_dup
< CRYPTO_EX_free
< CRYPTO_EX_new
< CRYPTO_MEM_LEAK_CB
< CRYPTO_dynlock
261d189
< CURCUR
298d225
< CoercionCodes
301d227
< CoercionMethod
326d251
< ConstraintExclusionType
360d284
< CreateStmtLikeOption
365d288
< Cred
376d298
< DCH_poz
381d302
< DH_METHOD
388,389d308
< DSA_METHOD
< DSA_SIG
395d313
< DatumPtr
417d334
< Dl_info
442,448d358
< ENGINE_CIPHERS_PTR
< ENGINE_CMD_DEFN
< ENGINE_CTRL_FUNC_PTR
< ENGINE_DIGESTS_PTR
< ENGINE_GEN_FUNC_PTR
< ENGINE_GEN_INT_FUNC_PTR
< ENGINE_LOAD_KEY_PTR
450,452d359
< ERR_FNS
< ERR_STATE
< ERR_STRING_DATA
454,457d360
< EVP_CIPHER
< EVP_CIPHER_CTX
< EVP_CIPHER_INFO
< EVP_ENCODE_CTX
460d362
< EVP_PBE_KEYGEN
495d396
< FF
500d400
< FUNMAP
535d434
< FormData_pg_description
553d451
< FormData_pg_shdescription
578d475
< Form_pg_description
596d492
< Form_pg_shdescription
618d513
< Function
629d523
< GEN_SESSION_CB
642,644d535
< GP
< GV
< GVOP
647d537
< GenericOptionFlags
660d549
< GinScanEntryData
676d564
< GlobalTransactionData
701,702d588
< HE
< HEK
704d589
< HISTORY_STATE
721d605
< HashJoinTableData
723d606
< HashJoinTupleData
740d622
< HeapScanDescData
747d628
< I16
749d629
< I8
751d630
< IO
755d633
< IV64
759,760d636
< IndexAttributeBitMap
< IndexAttributeBitMapData
773d648
< IndexScanDescData
784d658
< InhPaths
805,806d678
< ItemLength
< ItemOffset
810d681
< JMPENV
818,819d688
< KEYMAP_ENTRY
< KEYMAP_ENTRY_ARRAY
822,828c691,693
< Keymap
< LHASH
< LHASH_COMP_FN_TYPE
< LHASH_DOALL_ARG_FN_TYPE
< LHASH_DOALL_FN_TYPE
< LHASH_HASH_FN_TYPE
< LHASH_NODE
---
> LDAP
> LDAPMessage
> LDAP_TIMEVAL
830d694
< LISTOP
839,840d702
< LOGOP
< LOOP
870d731
< LockInfo
876d736
< LockTagType
882d741
< MAGIC
884,888d742
< MD2_CTX
< MD4_CTX
< MD5_CTX
< MDC2_CTX
< MGVTBL
898d751
< MergeJoinClauseData
914,916d766
< NETSCAPE_CERT_SEQUENCE
< NETSCAPE_SPKAC
< NETSCAPE_SPKI
921d770
< NUM_poz
944c793
< OBJ_NAME
---
> OM_uint32
976d824
< Outrec
979d826
< PADOFFSET
981,988d827
< PBE2PARAM
< PBEPARAM
< PBKDF2PARAM
< PEM_CTX
< PEM_ENCODE_SEAL_CTX
< PEM_USER
< PERL_CONTEXT
< PERL_SI
992d830
< PGErrorVerbosity
1018d855
< PGSSTrackLevel
1037,1047d873
< PKCS7
< PKCS7_DIGEST
< PKCS7_ENCRYPT
< PKCS7_ENC_CONTENT
< PKCS7_ENVELOPE
< PKCS7_ISSUER_AND_SERIAL
< PKCS7_RECIP_INFO
< PKCS7_SIGNED
< PKCS7_SIGNER_INFO
< PKCS7_SIGN_ENVELOPE
< PKCS8_PRIV_KEY_INFO
1097c923,933
< PMOP
---
> PLyDatumToOb
> PLyDatumToObFunc
> PLyObToDatum
> PLyObToTuple
> PLyPlanObject
> PLyProcedure
> PLyResultObject
> PLyTupleToOb
> PLyTypeInfo
> PLyTypeInput
> PLyTypeOutput
1117d952
< PV
1119d953
< PVOP
1125d958
< PacketLen
1157d989
< PerlExitListEntry
1206d1037
< PortalData
1233d1063
< PsqlScanStateData
1239a1070,1074
> PyMethodDef
> PyObject
> PySequenceMethods
> PyTypeObject
> Py_ssize_t
1256,1260d1090
< RAND_METHOD
< RC2_KEY
< RC4_KEY
< REGEXP
< RIPEMD160_CTX
1268d1097
< RSA_METHOD
1271d1099
< RUHashEntryData
1316d1143
< ResourceOwnerData
1330d1156
< RewriteStateData
1344,1348d1169
< SHA224_CTX
< SHA256_CTX
< SHA384_CTX
< SHA512_CTX
< SHA_CTX
1362,1367d1182
< SSL2_STATE
< SSL3_BUFFER
< SSL3_RECORD
< SSL3_STATE
< SSL_CIPHER
< SSL_COMP
1369,1370d1183
< SSL_METHOD
< SSL_SESSION
1373d1185
< SUBLEXINFO
1375d1186
< SVOP
1377d1187
< SaveArchivePtr
1398d1207
< SetConstraintTrigger
1404d1212
< SetOpHashEntryData
1420,1421d1227
< SigHandler
< Sighandler_t
1423d1228
< Sigsave_t
1478d1282
< SysScanDescData
1520,1537d1323
< TclStubHooks
< TclStubs
< Tcl_AppInitProc
< Tcl_AsyncHandler
< Tcl_AsyncProc
< Tcl_CallFrame
< Tcl_Channel
< Tcl_ChannelProc
< Tcl_ChannelType
< Tcl_ChannelTypeVersion
< Tcl_CloseProc
< Tcl_CmdDeleteProc
< Tcl_CmdInfo
< Tcl_CmdProc
< Tcl_CmdTraceProc
< Tcl_Command
< Tcl_Condition
< Tcl_CreateFileHandlerProc
1539,1565d1324
< Tcl_DeleteFileHandlerProc
< Tcl_DriverBlockModeProc
< Tcl_DriverClose2Proc
< Tcl_DriverCloseProc
< Tcl_DriverFlushProc
< Tcl_DriverGetHandleProc
< Tcl_DriverGetOptionProc
< Tcl_DriverHandlerProc
< Tcl_DriverInputProc
< Tcl_DriverOutputProc
< Tcl_DriverSeekProc
< Tcl_DriverSetOptionProc
< Tcl_DriverWatchProc
< Tcl_DupInternalRepProc
< Tcl_Encoding
< Tcl_EncodingConvertProc
< Tcl_EncodingFreeProc
< Tcl_EncodingState
< Tcl_EncodingType
< Tcl_EolTranslation
< Tcl_Event
< Tcl_EventCheckProc
< Tcl_EventDeleteProc
< Tcl_EventProc
< Tcl_EventSetupProc
< Tcl_ExitProc
< Tcl_FileFreeProc
1567,1568d1325
< Tcl_FreeInternalRepProc
< Tcl_FreeProc
1570d1326
< Tcl_HashSearch
1572d1327
< Tcl_IdleProc
1574,1579d1328
< Tcl_InterpDeleteProc
< Tcl_MainLoopProc
< Tcl_MathProc
< Tcl_Mutex
< Tcl_Namespace
< Tcl_NamespaceDeleteProc
1581,1600d1329
< Tcl_Obj
< Tcl_ObjCmdProc
< Tcl_ObjType
< Tcl_PackageInitProc
< Tcl_PanicProc
< Tcl_Parse
< Tcl_PathType
< Tcl_Pid
< Tcl_QueuePosition
< Tcl_RegExp
< Tcl_RegExpIndices
< Tcl_RegExpInfo
< Tcl_SavedResult
< Tcl_SetFromAnyProc
< Tcl_SetTimerProc
< Tcl_Stat_
< Tcl_TcpAcceptProc
< Tcl_ThreadCreateProc
< Tcl_ThreadDataKey
< Tcl_ThreadId
1602,1612d1330
< Tcl_TimerProc
< Tcl_TimerToken
< Tcl_Token
< Tcl_Trace
< Tcl_UniChar
< Tcl_UpdateStringProc
< Tcl_Value
< Tcl_ValueType
< Tcl_Var
< Tcl_VarTraceProc
< Tcl_WaitForEventProc
1618d1335
< Thread
1634d1350
< TrackFunctionsLevel
1659d1374
< TupleHashTableData
1680d1394
< U16
1682,1687d1395
< U8
< UI
< UI_METHOD
< UI_STRING
< UNDO_LIST
< UNOP
1699d1406
< VFunction
1741d1447
< WindowObjectData
1745d1450
< WindowStatePerFuncData
1754d1458
< WorkerInfoData
1761,1772d1464
< X509_ALGOR
< X509_ATTRIBUTE
< X509_CERT_AUX
< X509_CERT_FILE_CTX
< X509_CINF
< X509_CRL
< X509_CRL_INFO
< X509_EXTENSION
< X509_HASH_DIR_CTX
< X509_INFO
< X509_LOOKUP
< X509_LOOKUP_METHOD
1775,1782d1466
< X509_OBJECT
< X509_OBJECTS
< X509_PKEY
< X509_PUBKEY
< X509_REQ
< X509_REQ_INFO
< X509_REVOKED
< X509_SIG
1785,1786d1468
< X509_TRUST
< X509_VAL
1800,1813d1481
< XPV
< XPVAV
< XPVBM
< XPVCV
< XPVFM
< XPVGV
< XPVHV
< XPVIO
< XPVIV
< XPVLV
< XPVMG
< XPVNV
< XPVUV
< XRV
1818d1485
< XmlBinaryType
1824d1490
< XmlStandaloneType
1829,1832d1494
< _LIB_VERSION_TYPE
< _RuneEntry
< _RuneLocale
< _RuneRange
1835,1836d1496
< _ossl_old_des_cblock
< _ossl_old_des_key_schedule
1838d1497
< alloc_func
1840d1498
< assoc_list
1849d1506
< bio_info_cb
1858d1514
< caddr_t
1860d1515
< cc_t
1862,1863d1516
< char
< charf
1868d1520
< clockid_t
1869a1522
> cmpfunc
1870a1524
> coercion
1872,1875d1525
< comment_t
< conf_finish_func
< conf_init_func
< const_DES_cblock
1882,1883d1531
< cv_flags_t
< daddr_t
1888a1537
> destructor
1891,1892d1539
< div_t
< double
1894,1906d1540
< dyn_MEM_free_cb
< dyn_MEM_malloc_cb
< dyn_MEM_realloc_cb
< dyn_dynlock_create_cb
< dyn_dynlock_destroy_cb
< dyn_dynlock_lock_cb
< dyn_lock_add_lock_cb
< dyn_lock_locking_cb
< dynamic_LOCK_fns
< dynamic_MEM_fns
< dynamic_bind_engine
< dynamic_fns
< dynamic_v_check_fn
1912d1545
< expectation
1915d1547
< fd_mask
1917d1548
< filter_t
1924d1554
< fixpt_t
1926d1555
< float
1932,1936c1561
< fmStringInfo
< formarray
< formfloat
< fpos_t
< free_func
---
> freefunc
1964a1590,1594
> gss_OID
> gss_buffer_desc
> gss_cred_id_t
> gss_ctx_id_t
> gss_name_t
1965a1596
> hashfunc
1971,1972d1601
< in_addr_t
< in_port_t
1977d1605
< init_f
1978a1607
> inquiry
1980d1608
< int
1983,1984d1610
< int16_t
< int16m_t
1990d1615
< int32m_t
1994,1995d1618
< int64_t
< int64m_t
1997,1999d1619
< int8_t
< int8m_t
< intf
2003d1622
< jmp_buf
2005a1625,1632
> krb5_auth_context
> krb5_ccache
> krb5_context
> krb5_error
> krb5_error_code
> krb5_keytab
> krb5_principal
> krb5_ticket
2008d1634
< ldiv_t
2033d1658
< nlink_t
2042,2045d1666
< op_tr_array
< opcode
< opindex
< optType
2046a1668
> pam_handle_t
2048d1669
< pem_password_cb
2056a1678
> pg_gssinfo
2097,2105d1718
< pthread_attr_t
< pthread_cond_t
< pthread_condattr_t
< pthread_key_t
< pthread_mutex_t
< pthread_mutexattr_t
< pthread_once_t
< pthread_t
< ptrdiff_t
2108,2110d1720
< pvcontents
< q128_t
< qaddr_t
2112d1721
< quad_t
2116d1724
< regcomp_t
2118d1725
< regexec_t
2121d1727
< register_t
2123d1728
< regnode
2141,2143d1745
< rune_t
< runops_proc_t
< sa_family_t
2145d1746
< segsz_t
2149,2150d1749
< sig_t
< sighandler_cxt
2152d1750
< signedbitmapword
2157,2158d1754
< socklen_t
< speed_t
2165,2166d1760
< ssl_crock_st
< stack_t
2169d1762
< strconst
2173,2175d1765
< svindex
< svtype
< swblk_t
2177,2178d1766
< tcflag_t
< tcp_seq
2192,2195d1779
< uInt
< uIntf
< uLong
< uLongf
2198,2208d1781
< u_int16_t
< u_int16m_t
< u_int32_t
< u_int32m_t
< u_int64_t
< u_int64m_t
< u_int8_t
< u_int8m_t
< u_long
< u_quad_t
< u_short
2211d1783
< uint
2213a1786
> uint32_t
2216,2217c1789,1790
< unknown
< ushort
---
> uuid_rc_t
> uuid_t
2221d1793
< varattrib_1b
2223,2228d1794
< varattrib_4b
< vm_offset_t
< vm_size_t
< void
< voidp
< voidpf
2230,2231d1795
< wctype_t
< wint_t
2240d1803
< xl_dbase_create_rec_old
2242d1804
< xl_dbase_drop_rec_old
2264a1827,1838
> xmlBuffer
> xmlBufferPtr
> xmlChar
> xmlDocPtr
> xmlNodePtr
> xmlNodeSetPtr
> xmlParserCtxtPtr
> xmlTextWriter
> xmlTextWriterPtr
> xmlXPathCompExprPtr
> xmlXPathContextPtr
> xmlXPathObjectPtr
2265a1840
> xsltStylesheetPtr
2268c1843,1846
< yysigned_char
---
> yytype_int16
> yytype_int8
> yytype_uint16
> yytype_uint8