Re: Compiler warning

On Thursday 21 May 2009 14:29:51 Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > On Thursday 21 May 2009 10:01:59 Heikki Linnakangas wrote:
> >> Hmm, the patch looks fine to me. The strings are marked with
> >> gettext_noop() in the array, and passed through _() when used in errmsg.
> >
> > But his patch changes that to
> >
> > errhint("%s", _(wentry->drophint_msg))
> >
> > so it ends up being run through gettext twice.
>
> How so ?  errhint only passes its first argument through gettext.

Yeah, not thinking clearly.  So I guess this patch is OK if people care about 
that warning.