Re: Some 8.4 changes needed according to pg_migrator testing

Tom Lane wrote:

> 2. There seem to be some corner cases where creating a table in the new
> database will not create a toast table even though there was one in the
> previous instance.  (I'm not 100% convinced that this can happen if we
> create and then drop dropped columns, for instance ... but I'm not
> convinced it can't happen, either.)  If there is a toast table in the
> old database then pg_migrator must bring it over because it might
> possibly contain live data.  However, as toasting.c is presently coded
> there is no way to force it to create a toast table.  I think we should
> change AlterTableCreateToastTable to add a "bool force" parameter.
> Alternatively we could add a separate entry point, but the option seems
> a bit cleaner.

Hmm, what about toast reloptions?  They are not a problem now of course, but
could be in a 8.4->8.5 migration.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.