Re: unchecked out of memory in postmaster.c

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: unchecked out of memory in postmaster.c
Дата
Msg-id 20090407011113.GO4525@alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: unchecked out of memory in postmaster.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: unchecked out of memory in postmaster.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > I think a patch to solve this is as simple as the attached.
> 
> I guess I need to point out that those ereport calls already pose a far
> more substantial risk of palloc failure than the DLNewElem represents.

Hmm, do they?  I mean, don't they use ErrorContext, which is supposed to
be preallocated?

> You seem to have forgotten about releasing the DLElem if the fork fails,
> too.

Doh, sorry about that.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "David E. Wheeler"
Дата:
Сообщение: Re: A renewed plea for inclusion of zone.tab
Следующее
От: Tom Lane
Дата:
Сообщение: Re: unchecked out of memory in postmaster.c