Re: Window Functions: v07 APIs and buffering strateties

"Hitoshi Harada" <umi.tanuki@gmail.com> wrote:

> And I fixed this problem, confirming  with/without debug/cassert/gcc
> -O and push it to git. If you want delta patch, please see
>
http://git.postgresql.org/?p=~davidfetter/window_functions/.git;a=commitdiff;h=fbf19bfd0c8d2ac083b775f4cc724ec66e74fa8f

Now it passed all regression tests!


There is still one trivial warning:   parse_func.c: In function `ParseFuncOrColumn':   parse_func.c:77: warning:
'retval'might be used uninitialized in this function
 

It looks completely safe, but I suggest to initialize
the variable only to keep compiler quiet.

[src/backend/parser/parse_func.c] ParseFuncOrColumn()    else
+    {        elog(ERROR, "unknown function status");
+        retval = NULL;    /* keep compiler quiet */
+    }

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center