On Monday 05 May 2008 09:01:25 Andrew Dunstan wrote:
> Zeugswetter Andreas OSB sIT wrote:
> >>> Do we want the following:
> >>>
> >>> 1. pg_dump issues "set statement_timeout = 0;" to the
> >>
> >> database prior to
> >>
> >>> taking its copy of data (yes/no/default-but-switchable)
> >>> 2. pg_dump/pg_restore issue "set statement_timeout = 0;" in
> >>
> >> text mode
> >>
> >>> output (yes/no/default-but-switchable)
> >>> 3. pg_restore issues "set statement_timeout = 0;" to the
> >>
> >> database in
> >>
> >>> restore mode (yes/no/default-but-switchable)
> >>
> >> I think "yes" for all three. There was some handwaving about someone
> >> maybe not wanting it, but an utter lack of convincing use-cases; so
> >> I see no point in going to the effort of providing a switch.
> >>
ISTR being unconvinced by the pg_restore arguments, but as I think about it
some more, for someone to set statement_timeout on a production system, and
then have that be blindly overridden by any random pg_dump user seems a bit
unfair. pg_dump is not only used as a backup tool, it is also used as a
general user tool (for example, pgadmin calls pg_dump if you want to see a
tables schema). imho pg_dump should not set it by default, but have an option
to set it, specifically for the backup scenario.
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL