Re: DTrace probe patch for OS X Leopard

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: DTrace probe patch for OS X Leopard
Дата
Msg-id 200802290825.03207.peter_e@gmx.net
обсуждение исходный текст
Ответ на DTrace probe patch for OS X Leopard  (Robert Lor <Robert.Lor@Sun.COM>)
Ответы Re: DTrace probe patch for OS X Leopard  (Robert Lor <Robert.Lor@Sun.COM>)
Список pgsql-patches
Robert Lor wrote:
> Please find the patch attached per this thread
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg00912.php

Another thing that is concerning me about this new approach is the way the
probes are named.  For example, we'd now have a call

POSTGRESQL_LWLOCK_ACQUIRE()

in the code.  This does not say we are *tracing* lock aquisition, but it looks
like a macro that actually acquires a lock.

I understand that these probe names follow some global naming scheme.  Is it
hard to change that?  I'd feel more comfortable with, say,
(D)TRACE_POSTGRESQL_LWLOCK_ACQUIRE().

Comments?

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: tuplestore_putvalues()
Следующее
От: Teodor Sigaev
Дата:
Сообщение: Re: Proposed patch to change TOAST compression strategy