Re: Two fixes for plpgsql.sgml
От | Bruce Momjian |
---|---|
Тема | Re: Two fixes for plpgsql.sgml |
Дата | |
Msg-id | 200711282015.lASKFve27538@momjian.us обсуждение исходный текст |
Ответ на | Re: Two fixes for plpgsql.sgml (Guillaume Lelarge <guillaume@lelarge.info>) |
Ответы |
Re: Two fixes for plpgsql.sgml
|
Список | pgsql-docs |
Guillaume Lelarge wrote: > Neil Conway a ?crit : > > On Wed, 2007-11-28 at 08:17 +0100, Guillaume Lelarge wrote: > >> This patch fixes two issues on plpgsql.sgml. > > > > The first hunk seems like a regression to me: AFAICS the current > > phrasing is what is intended. > > > > *** 133,139 **** > > > > <para> > > <application>PL/pgSQL</> functions can also be declared to return > > ! a <quote>set</>, or table, of any data type they can return a > > single > > instance of. Such a function generates its output by executing > > <command>RETURN NEXT</> for each desired element of the result > > set, or by using <command>RETURN QUERY</> to output the result of > > --- 133,139 ---- > > > > <para> > > <application>PL/pgSQL</> functions can also be declared to return > > ! a <quote>set</>, or table, or any data type they can return a > > single > > instance of. Such a function generates its output by executing > > <command>RETURN NEXT</> for each desired element of the result > > set, or by using <command>RETURN QUERY</> to output the result of > > > > That's why I said that it needs to be reviewed carefully :) It just > means I didn't understand the sentence. Can you explain why the last > part is needed ? (the part that starts with "of any data type...") Agreed. I couldn't find any value to that phrase and couldn't find better wording, so I removed it. Patch attached and applied. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: doc/src/sgml/plpgsql.sgml =================================================================== RCS file: /cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v retrieving revision 1.118 diff -c -c -r1.118 plpgsql.sgml *** doc/src/sgml/plpgsql.sgml 28 Nov 2007 15:42:31 -0000 1.118 --- doc/src/sgml/plpgsql.sgml 28 Nov 2007 20:11:15 -0000 *************** *** 133,141 **** <para> <application>PL/pgSQL</> functions can also be declared to return ! a <quote>set</>, or table, of any data type they can return a single ! instance of. Such a function generates its output by executing ! <command>RETURN NEXT</> for each desired element of the result set, or by using <command>RETURN QUERY</> to output the result of evaluating a query. </para> --- 133,140 ---- <para> <application>PL/pgSQL</> functions can also be declared to return ! a <quote>set</>, or table. Such a function generates its output by ! executing <command>RETURN NEXT</> for each desired element of the result set, or by using <command>RETURN QUERY</> to output the result of evaluating a query. </para> *************** *** 1428,1434 **** WHERE fooid > 0 LOOP -- can do some processing here ! RETURN NEXT r; -- return next row of SELECT END LOOP; RETURN; END --- 1427,1433 ---- WHERE fooid > 0 LOOP -- can do some processing here ! RETURN NEXT r; -- return current row of SELECT END LOOP; RETURN; END
В списке pgsql-docs по дате отправления: