Re: WIN1252 encoding - backend or not?
От | Bruce Momjian |
---|---|
Тема | Re: WIN1252 encoding - backend or not? |
Дата | |
Msg-id | 200412041826.iB4IQjn05757@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: WIN1252 encoding - backend or not? (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: WIN1252 encoding - backend or not?
|
Список | pgsql-hackers |
Tom Lane wrote: > "Magnus Hagander" <mha@sollentuna.net> writes: > > But further down we have: > > #define PG_ENCODING_BE_LAST PG_WIN1250 > > Scarier than that is grepping the source code for -i win125, and noting > the number of places that cover the existing WIN125[016] encodings but > fail to mention WIN1252. In particular I notice that pg_wchar_table[] > in wchar.c has no entry added for WIN1252, which means that this patch > broke every encoding with higher code numbers. > > Bruce, I think this patch has to come out. We should not be in the > business of debugging a new feature post-RC1. OK, patch backed out and all added files removed. I will save the idea for 8.1. As far as the patch itself, I don't think I ever claimed it was ready for prime time --- rather, I followed process and it was applied. If Tom saying "it isn't ready for prime time" meant "back it out", I didn't read it that way. Of course anyone can ask for an applied patch to be backed out, as per procedure, and it is easily done. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 Index: src/backend/utils/mb/encnames.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/utils/mb/encnames.c,v retrieving revision 1.20 retrieving revision 1.21 diff -c -c -r1.20 -r1.21 *** src/backend/utils/mb/encnames.c 27 Sep 2004 23:24:33 -0000 1.20 --- src/backend/utils/mb/encnames.c 2 Dec 2004 22:14:36 -0000 1.21 *************** *** 2,8 **** * Encoding names and routines for work with it. All * in this file is shared bedween FE and BE. * ! * $PostgreSQL: pgsql/src/backend/utils/mb/encnames.c,v 1.20 2004/09/27 23:24:33 momjian Exp $ */ #ifdef FRONTEND #include "postgres_fe.h" --- 2,8 ---- * Encoding names and routines for work with it. All * in this file is shared bedween FE and BE. * ! * $PostgreSQL: pgsql/src/backend/utils/mb/encnames.c,v 1.21 2004/12/02 22:14:36 momjian Exp $ */ #ifdef FRONTEND #include "postgres_fe.h" *************** *** 194,199 **** --- 194,202 ---- "win1251", PG_WIN1251 }, /* alias for Windows-1251 */ { + "win1252", PG_WIN1252 + }, /* alias for Windows-1252 */ + { "win1256", PG_WIN1256 }, /* alias for Windows-1256 */ { *************** *** 221,226 **** --- 224,232 ---- "windows1251", PG_WIN1251 }, /* Windows-1251; Microsoft */ { + "windows1252", PG_WIN1252 + }, /* Windows-1252; Microsoft */ + { "windows1256", PG_WIN1256 }, /* Windows-1256; Microsoft */ { *************** *** 344,349 **** --- 350,358 ---- "WIN1250", PG_WIN1250 }, { + "WIN1252", PG_WIN1252 + }, + { "SJIS", PG_SJIS }, { Index: src/include/mb/pg_wchar.h =================================================================== RCS file: /cvsroot/pgsql/src/include/mb/pg_wchar.h,v retrieving revision 1.52 retrieving revision 1.53 diff -c -c -r1.52 -r1.53 *** src/include/mb/pg_wchar.h 17 Sep 2004 21:59:57 -0000 1.52 --- src/include/mb/pg_wchar.h 2 Dec 2004 22:14:38 -0000 1.53 *************** *** 1,4 **** ! /* $PostgreSQL: pgsql/src/include/mb/pg_wchar.h,v 1.52 2004/09/17 21:59:57 petere Exp $ */ #ifndef PG_WCHAR_H #define PG_WCHAR_H --- 1,4 ---- ! /* $PostgreSQL: pgsql/src/include/mb/pg_wchar.h,v 1.53 2004/12/02 22:14:38 momjian Exp $ */ #ifndef PG_WCHAR_H #define PG_WCHAR_H *************** *** 178,183 **** --- 178,184 ---- PG_ISO_8859_7, /* ISO-8859-7 */ PG_ISO_8859_8, /* ISO-8859-8 */ PG_WIN1250, /* windows-1250 */ + PG_WIN1252, /* windows-1252 */ /* followings are for client encoding only */ PG_SJIS, /* Shift JIS (Winindows-932) */
В списке pgsql-hackers по дате отправления: