Re: problem compiling 7.4.3

The attached patch fixes the problem.  You need to re-run configure and
recompile the code.  This will be fixed in 7.4.4 too.

---------------------------------------------------------------------------

Renney Thomas wrote:
> While compiling 7.4.3 on Solaris 8 (sparc) I got:
>
> rm -f thread.c && ln -s ../../../src/port/thread.c .
> gcc -pthreads -O3 -fno-strict-aliasing -Wall -Wmissing-prototypes
> -Wmissing-declar
> ations -fPIC -I. -I../../../src/include -I/usr/local/include
> -I/usr/local/ssl/incl
> ude -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -DFRONTEND
> -DSYSCONFDIR='"/usr/local/p
> gsql/etc"'  -c -o thread.o thread.c
> thread.c: In function `pqGetpwuid':
> thread.c:119: error: too few arguments to function `getpwuid_r'
> thread.c:119: warning: assignment makes pointer from integer without a cast
> gmake[3]: *** [thread.o] Error 1
> gmake[3]: Leaving directory `/opt/sft/postgresql-7.4.3/src/interfaces/libpq'
> gmake[2]: *** [all] Error 2
> gmake[2]: Leaving directory `/opt/sft/postgresql-7.4.3/src/interfaces'
> gmake[1]: *** [all] Error 2
> gmake[1]: Leaving directory `/opt/sft/postgresql-7.4.3/src'
>
>
> GCC:
> Reading specs from /usr/local/lib/gcc/sparc-sun-solaris2.8/3.4.0/specs
> Configured with: ../configure --with-as=/usr/ccs/bin/as
> --with-ld=/usr/ccs/bin/ld
> --disable-nls
> Thread model: posix
> gcc version 3.4.0
>
>
> SunOS  5.8 Generic_117350-02 sun4u sparc SUNW,Ultra-1
>
> Any patch files for this?
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
>                http://archives.postgresql.org
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: configure
===================================================================
RCS file: /cvsroot/pgsql-server/configure,v
retrieving revision 1.373
retrieving revision 1.374
diff -c -c -r1.373 -r1.374
*** configure    8 Jun 2004 14:06:35 -0000    1.373
--- configure    16 Jun 2004 02:58:24 -0000    1.374
***************
*** 13697,13705 ****
  fi
  done

- CFLAGS="$_CFLAGS"
- LIBS="$_LIBS"

  echo "$as_me:$LINENO: checking whether getpwuid_r takes a fifth argument" >&5
  echo $ECHO_N "checking whether getpwuid_r takes a fifth argument... $ECHO_C" >&6
  if test "${pgac_func_getpwuid_r_5arg+set}" = set; then
--- 13697,13704 ----
  fi
  done


+ # Do test here with thread flags
  echo "$as_me:$LINENO: checking whether getpwuid_r takes a fifth argument" >&5
  echo $ECHO_N "checking whether getpwuid_r takes a fifth argument... $ECHO_C" >&6
  if test "${pgac_func_getpwuid_r_5arg+set}" = set; then
***************
*** 13812,13817 ****
--- 13811,13819 ----

  fi

+
+ CFLAGS="$_CFLAGS"
+ LIBS="$_LIBS"

  else
  # do not use values from template file
Index: configure.in
===================================================================
RCS file: /cvsroot/pgsql-server/configure.in,v
retrieving revision 1.362
retrieving revision 1.363
diff -c -c -r1.362 -r1.363
*** configure.in    8 Jun 2004 14:06:35 -0000    1.362
--- configure.in    16 Jun 2004 02:58:28 -0000    1.363
***************
*** 989,999 ****
  CFLAGS="$CFLAGS $PTHREAD_CFLAGS"
  LIBS="$LIBS $PTHREAD_LIBS"
  AC_CHECK_FUNCS([strerror_r getpwuid_r gethostbyname_r])
- CFLAGS="$_CFLAGS"
- LIBS="$_LIBS"

  PGAC_FUNC_GETPWUID_R_5ARG
  PGAC_FUNC_STRERROR_R_INT

  else
  # do not use values from template file
--- 989,1001 ----
  CFLAGS="$CFLAGS $PTHREAD_CFLAGS"
  LIBS="$LIBS $PTHREAD_LIBS"
  AC_CHECK_FUNCS([strerror_r getpwuid_r gethostbyname_r])

+ # Do test here with thread flags
  PGAC_FUNC_GETPWUID_R_5ARG
  PGAC_FUNC_STRERROR_R_INT
+
+ CFLAGS="$_CFLAGS"
+ LIBS="$_LIBS"

  else
  # do not use values from template file