OK,
So if you agree that there is a quoting problem,and you don't mind
breaking backwards compatibility for it, I'll do a complete patch...
Chris
On Fri, 8 Aug 2003, Tom Lane wrote:
> "Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> > The situation seems to be a bug that this patch would address. It seems to
> > me that when a username is considered unsafe due to containing double
> > quotes, the double quotes should be escaped (and the backslashes)!
>
> > Does this look alright?
>
> I would personally say that the convention ought to match what is done
> in quoted identifiers, namely: " becomes "", backslash is not special
> and therefore doesn't need anything.
>
> More to the point, this is highly incomplete... you did not teach the
> adjacent getid routine about this, and there is code in (at least)
> pg_dump.c that knows the quoting conventions used here.
>
> regards, tom lane
>