Re: gcc3.3 compliance

Dear all,

I tried to rebuild the RedHat9 rpm, here is the log (gcc 3.2):

if g++ -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include
-I/usr/local/lib/wx/include/gtk2ud-2.5 -D__WXDEBUG__ -D__WXGTK__
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -I/usr/local/include
-DDATA_DIR=\"/usr/local/pgadmin3/share/pgadmin3/\" -Wall -g -I./include/ -I
-g -O2 -MT pgSet.o -MD -MP -MF ".deps/pgSet.Tpo" \
  -c -o pgSet.o `test -f 'db/pgSet.cpp' || echo './'`db/pgSet.cpp; \
then mv -f ".deps/pgSet.Tpo" ".deps/pgSet.Po"; \
else rm -f ".deps/pgSet.Tpo"; exit 1; \
fi
db/pgSet.cpp: Dans member function « long int pgSet::GetLong(const wxString&)
   »:
db/pgSet.cpp:123: choix de « long int pgSet::GetLong(int) const » à la place
   de « long int pgSet::GetLong(const wxString&) »
db/pgSet.cpp:123:   parce la plus mauvaise conversion de la déclaration
   initiale est meilleure que la plus mauvaise conversion de la dernière
   déclaration
make[2]: *** [pgSet.o] Erreur 1
make[2]: Quitte le répertoire `/usr/src/redhat/BUILD/pgadmin3-20030613/src'
make[1]: *** [all-recursive] Erreur 1
make[1]: Quitte le répertoire `/usr/src/redhat/BUILD/pgadmin3-20030613'
make: *** [all] Erreur 2
error: Bad exit status from /var/tmp/rpm-tmp.22060 (%build)

Cheers,
Jean-Michel

> Dave Page wrote:
> >>-----Original Message-----
> >>From: Jean-Michel POURE [mailto:jm.poure@freesurf.fr]
> >>Sent: 12 June 2003 16:50
> >>To: pgadmin-hackers@postgresql.org
> >>Cc: Adam Pendleton
> >>Subject: Re: [pgadmin-hackers] gcc3.3 compliance
> >>
> >>On Thursday 12 June 2003 17:09, you wrote:
> >>>Can you CVS update please? I fixed that yesterday (unless someone
> >>>un-fixed it again).
> >>
> >>This is an error output from today. It only occurs under SuSE
> >>82. Maybe we
> >>should wait for Adam patch review and then I will try again
> >>to compile under
> >>SuSE.
> >
> >Dunno what it is then. It is *exactly* the error I saw, on exactly the
> >same line of the file after Andreas commited a change. I added the cast
> >to long and it was fine.
>
> This fix breaks win32 compilation, and I really don't know what kind of
> foolishness gcc does here. All GetXXX pairs are defined equally, but
> only GetLong will show that problem.
> The argument to GetLong is an int, and ColNumber returns int, that
> should make a perfect fit. With the fix applied, msdev will complain
> "two similar conversions". Maybe it helps if all GetXXX(int) are defined
> as GetXXX(const int); please check this.
>
> Regards,
> Andreas
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org