Re: Error in chkpass.c (contrib area) with suggestion
От
Bruce Momjian
Тема
Re: Error in chkpass.c (contrib area) with suggestion
Дата
Msg-id
200211061801.gA6I1Ql11682@candle.pha.pa.us
Ответ на
Error in chkpass.c (contrib area) with suggestion (Sedlak Anton)
Список
Дерево обсуждения
Error in chkpass.c (contrib area) with suggestion Sedlak Anton <ased@cce.cz>
Re: Error in chkpass.c (contrib area) with suggestion Stephan Szabo <sszabo@megazone23.bigpanda.com>
Re: Error in chkpass.c (contrib area) with suggestion Bruce Momjian <pgman@candle.pha.pa.us>
Looks like 7.3beta has the null checking in the code. Thanks. --------------------------------------------------------------------------- Sedlak Anton wrote: > Because author is not responding I'm writing to you. > In contrib/chkpass.c there is no checking against NULL values on input, > thus if you call eg. raw(NULL) then postgresql always dies. > Although storing encrypted password are highly required this behavior > makes this extension module unusable. > > To correct it one must add some checkin before any PG_GETARG_XXX in > chkpass.c: > Suggested type of code follows: > ------------------------------------------------------------------ > if(PG_ARGISNULL(0)) PG_RETURN_NULL(); > ------------------------------------------------------------------ > > Best regards and let me know if this is acceptable > > Sedlak Anton > > > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
В списке pgsql-bugs по дате отправления
От: Peter Eisentraut
Дата: