Re: pg_upgrade cmdline issue

Simone Tellini wrote:
>
> On 11 Feb 2002 09:35:46 +0100
> Markus Bertheau <twanger@bluetwanger.de> wrote:
>
> MB> bash-2.05$ bin/pg_upgrade -D /var/lib/pgsql/data/ -1
> MB> You must run pg_upgrade in either mode 1 or mode 2.
> MB> Usage:  pg_upgrade [-D datadir] -1 | -2
> MB> bash-2.05$
>
> I've got that too. Try export PGDATA=/var/lib/pgsql/data, then
> pg_upgrade -1

Patch attached and will appear in 7.2.1.  I need more reports on
pg_upgrade, working or failing.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: contrib/pg_upgrade/pg_upgrade
===================================================================
RCS file: /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade,v
retrieving revision 1.11
diff -c -r1.11 pg_upgrade
*** contrib/pg_upgrade/pg_upgrade    2002/01/31 19:13:53    1.11
--- contrib/pg_upgrade/pg_upgrade    2002/02/11 15:14:08
***************
*** 34,41 ****
  BASENAME=`basename "$0"`
  PHASE=""

! if [ "$#" -eq 1 ]
! then
      if [ "X$1" = "X-1" ]
      then    PHASE="1"
          shift
--- 34,41 ----
  BASENAME=`basename "$0"`
  PHASE=""

! while [ "$#" -ne 0 ]
! do
      if [ "X$1" = "X-1" ]
      then    PHASE="1"
          shift
***************
*** 46,52 ****
      then    PGDATA="$2"
          shift 2
      fi
! fi

  if [ "$PHASE" = "" ]
  then    echo "You must run $BASENAME in either mode 1 or mode 2." 1>&2
--- 46,52 ----
      then    PGDATA="$2"
          shift 2
      fi
! done

  if [ "$PHASE" = "" ]
  then    echo "You must run $BASENAME in either mode 1 or mode 2." 1>&2