Re: CURRENT/OLD keywords still broken

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: CURRENT/OLD keywords still broken
Дата
Msg-id 200012152336.SAA09486@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: CURRENT/OLD keywords still broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
OK, compatibility mapping removed.

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > That was me.  The old code did old -> current, so I changed it to do
> > current -> old.  How else can I fix this?  Attached is the old patch.
> 
> But CURRENT was strictly an internal token name, not a string the user
> could actually see.  So there's no need to have
> +     /* for portability with old rules bjm 2000-06-12 */
> +     {"current", OLD},
> 
> The only way that there would be a compatibility problem would be if
> ruleutils.c had been set up to print CURRENT, but it wasn't:
> 
> *** 1278,1284 ****
>                                          quote_identifier(rte->relname));
>                     else if (!strcmp(rte->ref->relname, "*NEW*"))
>                         appendStringInfo(buf, "new.");
> !                       else if (!strcmp(rte->ref->relname, "*CURRENT*"))
>                         appendStringInfo(buf, "old.");
>                     else
>                         appendStringInfo(buf, "%s.",
> --- 1278,1284 ----
>                                          quote_identifier(rte->relname));
>                     else if (!strcmp(rte->ref->relname, "*NEW*"))
>                         appendStringInfo(buf, "new.");
> !                       else if (!strcmp(rte->ref->relname, "*OLD*"))
>                         appendStringInfo(buf, "old.");
>                     else
> 
> NEW and OLD are what the user see, and have been for awhile.  So there's
> no compatibility issue here.
> 
>         regards, tom lane
> 


--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: CURRENT/OLD keywords still broken
Следующее
От: "mike"
Дата:
Сообщение: TOAST documentation