Re: New developer papercut - Makefile references INSTALL

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: New developer papercut - Makefile references INSTALL
Дата
Msg-id 1ce1430e-1f1b-32da-b6c9-9b63153c51d9@enterprisedb.com
обсуждение исходный текст
Ответ на Re: New developer papercut - Makefile references INSTALL  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: New developer papercut - Makefile references INSTALL  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On 18.01.22 16:51, Daniel Gustafsson wrote:
>> On 17 Jan 2022, at 13:26, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 17 Jan 2022, at 11:25, Magnus Hagander <magnus@hagander.net> wrote:
>>
>>> That said, I'm not sure we're actually gaining anything by *not*
>>> referring to the website as well. TBH, I bet the majority of users
>>> will actually prefer to read them there. So I'd suggest always
>>> including the reference to the website as well, per the suggestion
>>> from Tim.
>>
>> Fair point, I'll go ahead and do that in a bit unless anyone objects.
> 
> I plan on applying the attached which address the feedback given.

The indentation of the two INSTRUCTIONS= lines uses a different mix of 
tabs and spaces, so it looks a bit weird depending on how you view it.

It's also a bit strange that the single quotes are part of the value of 
$INSTRUCTIONS rather than part of the fixed text.

The URL links to the "devel" version of the installation instructions, 
which will not remain appropriate after release.  I don't know how to 
fix that without creating an additional maintenance point.  Since 
README.git already contains that link, I would leave off the web site 
business and just make the change of the dynamically chosen file name.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Daniel Gustafsson
Дата:
Сообщение: Re: New developer papercut - Makefile references INSTALL
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: Pluggable toaster