On 23.02.23 08:51, Peter Eisentraut wrote:
> In kwlist.h you have
>
> PG_KEYWORD("indent", INDENT, UNRESERVED_KEYWORD, AS_LABEL)
>
> but you can actually make it BARE_LABEL, which is preferable.
>
> More importantly, you need to add the new keyword to the
> bare_label_keyword production in gram.y. I thought we had some
> tooling in the build system to catch this kind of omission, but it's
> apparently not working right now.
Entry in kwlist.h changed to BARE_LABEL.
>
> Elsewhere, let's rename the xmlformat() C function to xmlserialize()
> (or maybe something like xmlserialize_indent()), so the association is
> clearer.
>
xmlserialize_indent sounds much better and makes the association indeed
clearer. Changed in v19.
v19 attached.
Thanks for the review!
Best, Jim