Re: code cleanup: ss_currentScanDesc

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: code cleanup: ss_currentScanDesc
Дата
Msg-id 17885.1267164228@sss.pgh.pa.us
обсуждение исходный текст
Ответ на code cleanup: ss_currentScanDesc  (Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>)
Список pgsql-hackers
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
> ScanState.ss_currentScanDesc is currently used by only SeqScan and
> BitmapHeapScan. Other scan nodes don't use the field at all, right?

> Can we move the field into SeqScanState and BitmapHeapScanState
> for code cleanup? This change will not improve any performance,
> but it can clear up what we do actually.

Why is that an improvement?  ISTM that the fact that other scan types
don't use a scandesc pointer is the oddity, not that these do.  You'd
also be making it harder to share any code between these two cases.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Дмитрий Фефелов
Дата:
Сообщение: Re: Alpha4 Available Now
Следующее
От: Gokulakannan Somasundaram
Дата:
Сообщение: Re: A thought on Index Organized Tables