Обсуждение: code cleanup: ss_currentScanDesc

Поиск
Список
Период
Сортировка

code cleanup: ss_currentScanDesc

От
Takahiro Itagaki
Дата:
ScanState.ss_currentScanDesc is currently used by only SeqScan and
BitmapHeapScan. Other scan nodes don't use the field at all, right?

Can we move the field into SeqScanState and BitmapHeapScanState
for code cleanup? This change will not improve any performance,
but it can clear up what we do actually.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Вложения

Re: code cleanup: ss_currentScanDesc

От
Tom Lane
Дата:
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
> ScanState.ss_currentScanDesc is currently used by only SeqScan and
> BitmapHeapScan. Other scan nodes don't use the field at all, right?

> Can we move the field into SeqScanState and BitmapHeapScanState
> for code cleanup? This change will not improve any performance,
> but it can clear up what we do actually.

Why is that an improvement?  ISTM that the fact that other scan types
don't use a scandesc pointer is the oddity, not that these do.  You'd
also be making it harder to share any code between these two cases.
        regards, tom lane