Re: [HACKERS] kqueue

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] kqueue
Дата
Msg-id 17596.1579539313@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [HACKERS] kqueue  (Thomas Munro <thomas.munro@gmail.com>)
Список pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> [ 0001-Add-kqueue-2-support-for-WaitEventSet-v13.patch ]

I haven't read this patch in any detail, but a couple quick notes:

* It needs to be rebased over the removal of pg_config.h.win32
--- it should be touching Solution.pm instead, I believe.

* I'm disturbed by the addition of a hunk to the supposedly
system-API-independent WaitEventSetWait() function.  Is that
a generic bug fix?  If not, can we either get rid of it, or
at least wrap it in "#ifdef WAIT_USE_KQUEUE" so that this
patch isn't inflicting a performance penalty on everyone else?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] kqueue
Следующее
От: David Fetter
Дата:
Сообщение: Increase psql's password buffer size