On 8/23/21 2:00 PM, Platon Pronko wrote:
> Hi!
>
> Apparently I did forget something, and that's the patch itself :)
> Thanks for Justin Pryzby for pointing this out.
>
> Attaching the patch now.
>
>
(Please avoid top-posting on PostgreSQL lists)
This patch seems basically sound. A couple of things:
1. It's not following project indentation style (BSD brace placement)
2. It would possibly be better to pass the relevant parts of the options
to print_aligned_vertical_line() rather than the whole options
structure. It feels odd to pass both that and opt_border.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com