I agreed with the changes. Thank you for your work.
I updated patch and added you to the authors.
I specified Ranier Vilela as a reviewer.
On 10.07.2023 06:12, Andrey Lepikhov wrote:
> On 7/7/2023 15:20, Alena Rybakina wrote:
>>
>> because we will provide similar manipulation in this:
>>
>> foreach(l, gentry->consts)
>> {
>> Node *rexpr = (Node *) lfirst(l);
>>
>> rexpr = coerce_to_common_type(pstate, rexpr,
>> scalar_type,
>> "IN");
>> aexprs = lappend(aexprs, rexpr);
>> }
> I'm not sure that it should be replaced.
> In attachment - a bit more corrections to the patch.
> The most important change - or_list contains already transformed
> expression subtree. So, I think we don't need to free it at all.
>
--
Regards,
Alena Rybakina
Postgres Professional