Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Shouldn't attribute_used() be removed from rewriteManip.h?
Yeah, I don't know how I missed that. Thanks.
> I was a bit surprised by your removal of the
> rangeTableEntry_used() test in the hunk at
> rewriteHandler.c:1273ff. That's probably all right, but it takes
> this out of the realm of a mechanical change.
[ also questioned by Álvaro ]
I'll leave that as it was -- it can be discussed separately from
the mechanical changes.
New patch attached.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company