Re: MV patch broke users of ExplainOneQuery_hook

Robert Haas <robertmhaas@gmail.com> wrote:

> The materialized views patch adjusted ExplainOneQuery to take an
> additional DestReceiver argument, but failed to add a matching
> argument to the definition of ExplainOneQuery_hook.  This makes the
> hook unusable.  The idea of this hook is that your hook function will
> do something before and/or after calling pg_plan_query and
> ExplainOnePlan.  But this no longer works, because ExplainOnePlan
> needs the DestReceiver, which hasn't been exposed to the hook.  :-(

Feel free to go ahead and fix this if you like; otherwise I'll look
at it later today.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company