Re: Add comments for a postgres program in bootstrap mode

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Add comments for a postgres program in bootstrap mode
Дата
Msg-id 13139.1569511378@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Add comments for a postgres program in bootstrap mode  (Youki Shiraishi <shiraishi@computer.org>)
Ответы Re: Add comments for a postgres program in bootstrap mode  (Youki Shiraishi <shiraishi@computer.org>)
Список pgsql-hackers
Youki Shiraishi <shiraishi@computer.org> writes:
> On Thu, Sep 26, 2019 at 5:38 PM Amit Langote <amitlangote09@gmail.com> wrote:
>>   * The main entry point for auxiliary processes, such as the bgwriter,
>> - * walwriter, walreceiver, bootstrapper and the shared memory checker code.
>> + * walwriter, walreceiver, postgres program in bootstrap mode and the
>> + * shared memory checker code.
>>
>> This change may not be necessary, because, bootstrapper is a good
>> short name for 'postgres program in bootstrap mode'.  Also, this name
>> is similar in style to the names of other auxiliary processes.

> Thank you for reviewing my patch.
> My concern is that the word 'bootstrapper' is ambiguous.
> If the word is obvious to hackers, please use the v2 patch attached to
> this email.

A quick grep through the sources finds that "bootstrapper" is used
in exactly two places (here, and one comment in initdb.c).  I don't
think it's accepted jargon at all, and would vote to get rid of it.
What I think *is* the usual phrasing is "bootstrap-mode backend"
or variants of that.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Unstable select_parallel regression output in 12rc1
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: dropdb --force