On Sun, 2008-01-27 at 12:45 -0500, Tom Lane wrote:
> Maybe a GUC variable to enable/disable syncscan?
The first iterations of the patch included a GUC.
I don't have any objection to re-introducing a GUC to enable/disable it.
However, I would suggest that it defaults to "on", because:
1. There aren't many cases where you'd want it to be off, and this
particular case with pg_dump is the best one that I've heard of (thanks
Greg). We want people who install 8.3 to see a boost without lots of
tuning, if possible.
2. It only turns on for tables over 25% of shared buffers anyway.
Introducing GUCs reintroduces the same questions that were discussed
before.
1. Should the 25% figure be tunable as well?
2. Remember that the 25% figure is also tied to Simon and Heikki's
buffer recycling patch (buffer ring patch). Should they be configurable
independently? Should they be tied together, but configurable?
The simplest solution, in my opinion, is something like:
large_scan_threshold = 0.25 # set to -1 to disable
Where a scan of any table larger than (large_scan_threshold *
shared_buffers) employs both synchronized scans and buffer recycling. We
may implement other large scan strategies in the future.
Regards,Jeff Davis