Fujita-san,
On 2018/01/29 15:15, Etsuro Fujita wrote:
> (2018/01/29 9:50), Amit Langote wrote:
>> On 2018/01/26 21:31, Etsuro Fujita wrote:
>>> Attached is a modified
>>> version of the patch. What do you think about that? Please let me know.
>>> If that is okay, I'll mark this as Ready for Committer.
>>
>> That looks good, thanks.
>
> Cool! One thing I noticed to revise the patch a bit further is to add an
> assertion to make_partition_op_expr that the number of the right-hand
> inputs to generate an operator expression from for list-partitioning
> should be >=1; in that case we call that function if there is at least one
> non-null partition value as the right-hand input, so that should be
> asserted successfully there. I think the assertion is a good thing, so I
> modified the patch.
Ah, good call.
> Updated patch attached. Because I made no changes
> other than that, I'll make this as Ready for Committer.
Thanks a lot for reviewing.
Regards,
Amit