Re: how is pitr replay interruption time determined?

On Tue, 2007-08-28 at 18:49 -0400, Tom Lane wrote:
> Simon Riggs <simon@2ndquadrant.com> writes:
> > Yeh, we traced a problem with GIN indexes to this cause in early June;
> > Teodor fixed it quickly in REL8_2_STABLE, but that won't be available
> > until 8.2.5.
>
> Thanks, that's what I missed finding ... Robert, do you have any GIN
> indexes in this DB?
>
> > I'd be happier with a log message to say
> >   ereport(DEBUG2,
> >     (errmsg("RM %d not safe to record restart point at %X/%X",
> >             rmid,
> >             checkPoint->redo.xlogid,
> >             checkPoint->redo.xrecoff)));
> > to help trace such things in future.
>
> As long as it's DEBUG2 or so, no objection here.

OK, I'll do up a patch.

References:
- GIN error trace patch on pgsql-general
http://archives.postgresql.org/pgsql-general/2007-06/msg00072.php
- Committed fixes
http://archives.postgresql.org/pgsql-committers/2007-06/msg00061.php

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com