Re: [Proposal] Level4 Warnings show many shadow vars

Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Dec 8, 2019 at 1:52 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't think I'm actually on board with the goal here.

> I don't know what to do about the RedoRecPtr mess, but surely
> subscriptioncmds.c's use of synchronous_commit as a char * when it's
> already exists as a global variable of type int is not good practice.

Well, again, this is a case-by-case question.  I tend to agree that
changing that usage in subscriptioncmds.c might be a good idea.
That doesn't mean I need to be on board with wholesale removal
of shadowing warnings.

            regards, tom lane