Re: effective_cache_size vs units
От | Joshua D. Drake |
---|---|
Тема | Re: effective_cache_size vs units |
Дата | |
Msg-id | 1166576669.22487.173.camel@localhost.localdomain обсуждение исходный текст |
Ответ на | Re: effective_cache_size vs units (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: effective_cache_size vs units
Re: effective_cache_size vs units |
Список | pgsql-hackers |
On Tue, 2006-12-19 at 19:16 -0500, Tom Lane wrote: > Peter Eisentraut <peter_e@gmx.net> writes: > > Perhaps it would be more effective to clarify the error message? Right > > now it just says something to the effect of "invalid integer". I'd > > imagine "invalid memory unit: TB" would be less confusing. > > +1 on that, but I think we should just accept the strings > case-insensitively, too. SQL in general is not case sensitive for > keywords, and neither is anything else in the postgresql.conf file, > so I argue it's inconsistent to be strict about the case for units. Hello, Attached is a simple patch that replaces strcmp() with pg_strcasecmp(). Thanks to AndrewS for pointing out that I shouldn't use strcasecp(). I compiled and installed, ran an initdb with 32mb (versus 32MB) and it seems to work correctly with a show shared_buffers; Sincerely, Joshua D. Drake -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
Вложения
В списке pgsql-hackers по дате отправления: