Alvaro Herrera <alvherre@commandprompt.com> writes:
> This version should fix these issues. I refrained from adding more ? :
> expressions because it starts getting ugly for my taste.
I think you might as well just introduce two separate code paths to
produce the 8.4 and pre-8.4 queries, so that you don't need the LEFT
JOIN in the pre-8.4 path. IMHO the cut-and-paste way that we usually
do it in pg_dump is a whole lot easier to read and maintain than this
sort of ?: spaghetti.
regards, tom lane